[DI] Switch container to Laravel - final step 🥳#4698
Merged
TomasVotruba merged 10 commits intomainfrom Aug 15, 2023
Merged
Conversation
c67d2e6 to
21bc0af
Compare
6d5f849 to
718316a
Compare
samsonasik
reviewed
Aug 8, 2023
samsonasik
reviewed
Aug 13, 2023
...tests/Instanceof_/Rector/Ternary/FlipNegatedTernaryInstanceofRector/Fixture/correct_case.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 14, 2023
.../NodeTypeResolver/Reflection/BetterReflection/RectorBetterReflectionSourceLocatorFactory.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Aug 14, 2023
staabm
reviewed
Aug 14, 2023
staabm
reviewed
Aug 14, 2023
staabm
reviewed
Aug 14, 2023
staabm
approved these changes
Aug 14, 2023
Contributor
staabm
left a comment
There was a problem hiding this comment.
I really like it. just commented a few nits.
samsonasik
approved these changes
Aug 14, 2023
Member
Author
|
The night is coming... let's do this 🚀 |
Member
Author
|
First rector build on Laravel DI is here: So far, the vendor is downgraded correctly ✔️ Now it's time to remove the symfony dependencies |
Member
Author
|
Here is list of removed packages, including composer-unused that also required symfony di:
|
This was referenced Aug 15, 2023
Member
Author
|
Here it the rector/rector deploy diff commit without all the Symfony packages:
This means we don't have to downgrade all these packages anymore and can avoid the Symfony container patching 🥳 |
Member
Author
|
Here is the post about extension upgrade and size difference between containers 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo after merge