StaticMapper: added fast path for IdentifierTypeNode#4565
Merged
samsonasik merged 6 commits intorectorphp:mainfrom Jul 21, 2023
Merged
StaticMapper: added fast path for IdentifierTypeNode#4565samsonasik merged 6 commits intorectorphp:mainfrom
samsonasik merged 6 commits intorectorphp:mainfrom
Conversation
Contributor
Author
|
I guess the test-suite segfaults because of a infinite loop. I couldn't identify yet why this happens. I can also see it locally but wanted to verify in CI whether the problem also happens |
Contributor
Author
|
updated the initial description with our results. with this change rector runs 23% faster in our use-case which means saving 1 minute on a 4 minute job additionally we are saving 11% on memory usage |
Contributor
Author
|
I think we are good to go |
samsonasik
approved these changes
Jul 21, 2023
samsonasik
reviewed
Jul 21, 2023
Member
|
Let's give it a try, thank you @staabm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the idea behind this method is:
$typeNode=IdentifierTypeNodeso we can skip name scope creationResult: 1 minute faster rector runs ; additionally we are saving 11% on memory usage
closes rectorphp/rector#8077