Merged
Conversation
7332024 to
4aee2de
Compare
2640269 to
32741f8
Compare
TomasVotruba
commented
Jul 20, 2023
Comment on lines
-96
to
-109
| /** | ||
| * @param string[] $commandLinePaths | ||
| * @return string[] | ||
| */ | ||
| private function correctBashSpacePaths(array $commandLinePaths): array | ||
| { | ||
| // fixes bash edge-case that to merges string with space to one | ||
| foreach ($commandLinePaths as $commandLinePath) { | ||
| if (\str_contains($commandLinePath, ' ')) { | ||
| $commandLinePaths = explode(' ', $commandLinePath); | ||
| } | ||
| } | ||
|
|
||
| return $commandLinePaths; |
Member
Author
There was a problem hiding this comment.
This actually incorrectly splits any spaced path to 2 strings:
/some directory/file.phpwill result into:
/some
directory/file.php
Member
|
@paulbalandan could you verify this on windows? Try latest rector/rector:dev-main. Thank you. |
Contributor
|
@samsonasik I used PS C:\Users\P\Desktop\Web Dev\CodeIgniter4> vendor/bin/rector process system
Could not open input file: C:\Users\P\Desktop\Web |
Member
|
@paulbalandan thank you for check. @TomasVotruba it may need to use e2e for windows. @paulbalandan could you help create a reproducible e2e or github repo with windows running ( vendor committed ) to allow debug in there? Thank you. |
Member
|
@TomasVotruba the issue on windows seems the root path before project path that may contains space |
Member
Author
|
@samsonasik I see 👍 . I don't use Windows so I can't help much. Having a e2e test case would give us at least regression check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#8005