PreparedValueToEarlyReturnRector creates invalid code#4528
Closed
kkmuffme wants to merge 1 commit intorectorphp:mainfrom
Closed
PreparedValueToEarlyReturnRector creates invalid code#4528kkmuffme wants to merge 1 commit intorectorphp:mainfrom
kkmuffme wants to merge 1 commit intorectorphp:mainfrom
Conversation
There are some options to change this to early return, however I'm not sure if this is wanted here (since it would mean you'd have to concat in the return), so I suggested to not change the code at all (instead of creating invalid code as it does now)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some options to change this to early return, however I'm not sure if this is wanted here (since it would mean you'd have to concat in the return), so I suggested to not change the code at all (instead of creating invalid code as it does now)