[Application] Move filter files by config extensions to FileFactory#4522
Merged
samsonasik merged 1 commit intomainfrom Jul 15, 2023
Merged
[Application] Move filter files by config extensions to FileFactory#4522samsonasik merged 1 commit intomainfrom
samsonasik merged 1 commit intomainfrom
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba @staabm this continue of PR:
to move filter file paths by extensions to
FileFactory::findFilesInPaths()itself to avoid missplaced re-filter paths again in the future 👍