Skip to content

[CodeQuality] Skip multiple assigns append before foreach on ForeachItemsAssignToEmptyArrayToAssignRector#4052

Merged
samsonasik merged 3 commits into
mainfrom
skip-multiple-assign
Jun 2, 2023
Merged

[CodeQuality] Skip multiple assigns append before foreach on ForeachItemsAssignToEmptyArrayToAssignRector#4052
samsonasik merged 3 commits into
mainfrom
skip-multiple-assign

Conversation

@samsonasik

@samsonasik samsonasik commented Jun 2, 2023

Copy link
Copy Markdown
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 2, 2023 21:25
@samsonasik

samsonasik commented Jun 2, 2023

Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @mpesari

@samsonasik samsonasik changed the title [CodeQuality] Skip multiple assigns before foreach on ForeachItemsAssignToEmptyArrayToAssignRector [CodeQuality] Skip multiple assigns append before foreach on ForeachItemsAssignToEmptyArrayToAssignRector Jun 2, 2023
@samsonasik

samsonasik commented Jun 2, 2023

Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 069e53a into main Jun 2, 2023
@samsonasik samsonasik deleted the skip-multiple-assign branch June 2, 2023 22:00
@samsonasik samsonasik mentioned this pull request Jun 3, 2023
Merged
@mpesari

mpesari commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ForeachItemsAssignToEmptyArrayToAssignRector

2 participants

@samsonasik @mpesari