Skip StrvalToType for strval first class callable syntax#4046
Merged
TomasVotruba merged 2 commits intoJun 2, 2023
Merged
Conversation
993f172 to
e6dbb57
Compare
samsonasik
approved these changes
Jun 2, 2023
e6dbb57 to
e3243c0
Compare
Member
|
Rebase seems needed |
21db869 to
2effb90
Compare
Member
|
Test error seems unrelated, we can wait until all green on main branch first, then rebase once more :) |
Member
|
Looks good 👍 Let's ship it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7970