Workaround fix for missing newline in attributes in ReadOnlyClassRector#3839
Merged
TomasVotruba merged 2 commits intomainfrom May 14, 2023
Merged
Workaround fix for missing newline in attributes in ReadOnlyClassRector#3839TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
91e7440 to
7462acd
Compare
Member
Author
|
Just looking into it. This is a bug in php-parser in formatPreservingPrinter. The input here is valid and class node itself is printed correctly, if the orig node is made null. I've added a workaround to reprint the whole Class_ from scratch, but php-parser fix is needed. |
Member
Author
|
Possibly related is this PR in php-parser: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#7734