Skip to content

Added failling declare-strict test#3646

Closed
staabm wants to merge 1 commit intorectorphp:mainfrom
staabm:patch-1
Closed

Added failling declare-strict test#3646
staabm wants to merge 1 commit intorectorphp:mainfrom
staabm:patch-1

Conversation

@staabm
Copy link
Copy Markdown
Contributor

@staabm staabm commented Apr 22, 2023

currently declare-strict is added twice

see https://getrector.com/demo/8f12e669-40a2-406e-aea8-0067d8418876

currently declare-strict is added twice
@samsonasik
Copy link
Copy Markdown
Member

That's seems only on FileWithoutNamespace, with next InlineHTML node, as detecting first node is first node stmts itself, on namespace, it works as expected https://getrector.com/demo/28f3b784-3697-4578-94d5-8e3452f9b3c5

@samsonasik samsonasik self-assigned this Apr 22, 2023
@samsonasik
Copy link
Copy Markdown
Member

I will look into it

@samsonasik
Copy link
Copy Markdown
Member

@staabm I cherry-picked your commit at PR #3648

@staabm
Copy link
Copy Markdown
Contributor Author

staabm commented Apr 22, 2023

thank you

@staabm staabm closed this Apr 22, 2023
@staabm staabm deleted the patch-1 branch April 22, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants