Skip to content

[DX] Allow --clear-cache to be configured via configuration file#3599

Closed
yguedidi wants to merge 1 commit intorectorphp:mainfrom
yguedidi:clear-cache-config
Closed

[DX] Allow --clear-cache to be configured via configuration file#3599
yguedidi wants to merge 1 commit intorectorphp:mainfrom
yguedidi:clear-cache-config

Conversation

@yguedidi
Copy link
Copy Markdown
Contributor

@yguedidi yguedidi commented Apr 10, 2023

Typical command I run on my projects when running a single rector over the whole code is: vendor/bin/rector process --memory-limit=4G --no-diffs --clear-cache
I'd like to improve the DX by just running vendor/bin/rector. so after #3598 I continued by the second easiest one to support in configuration file :)

@TomasVotruba
Copy link
Copy Markdown
Member

Hi, thanks for the proposal.
This is rather just-in-time option visible in CLI call, that should be visible as it affects performance heavily. So we only want it in CLI.

@yguedidi yguedidi deleted the clear-cache-config branch April 10, 2023 14:27
@yguedidi
Copy link
Copy Markdown
Contributor Author

Completely fine! Thinking about it twice I could remove it from my default command already, as changing the config automatically clear the cache 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants