Performance: Improve NodeTypeResolver::isObjectType() performance#3500
Closed
keulinho wants to merge 1 commit intorectorphp:mainfrom
Closed
Performance: Improve NodeTypeResolver::isObjectType() performance#3500keulinho wants to merge 1 commit intorectorphp:mainfrom
keulinho wants to merge 1 commit intorectorphp:mainfrom
Conversation
samsonasik
reviewed
Mar 22, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
Type may changed on node refactored by other rules, so it can't be cached.
Member
|
I am going to close it as the node type can be changed on refactored by other rules that follow the scope :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeTypeResolver::isObjectType()is called from multiple rectory on the same node and taking quite a long time.By saving the resolved type to the node for later reuse and checking if a object type is actually a trait before analysing all traits improves performance by ~30% in our test run.
see the blackfire comparison here: https://blackfire.io/profiles/compare/49347102-5585-4e90-9a9c-9b4f5e8b74fb/graph