[ci] put primary condition to rector github action run#3439
Closed
TomasVotruba wants to merge 2 commits intomainfrom
Closed
[ci] put primary condition to rector github action run#3439TomasVotruba wants to merge 2 commits intomainfrom
TomasVotruba wants to merge 2 commits intomainfrom
Conversation
9f36a9c to
34fbf9e
Compare
samsonasik
reviewed
Mar 2, 2023
| ## here can't be --dry-run, as the change results in error code 1 and stops the job without commiting in the future | ||
| - run: bin/rector process ${{ matrix.paths }} --ansi | ||
|
|
||
| - run: vendor/bin/ecs check --fix --ansi |
Member
There was a problem hiding this comment.
cs fix still needed after apply rector
Member
Author
There was a problem hiding this comment.
This is to comply with dependency-less defaults, to make it easier to spread and use our own command to generate it on the fly :)
We'll use the coding standard in standalone run.
Member
|
Also, rector workflow is pending with this |
Member
|
I will create separate alternative PR |
Member
Author
Hm, that looks like some bug. The condition is possibly using wrong string 🤔 |
34fbf9e to
45f7418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samsonasik I had this in mind :) suggested by ChatGPT
Could you test it on the use case that was failing?