[CleanupUnneededNullsafeOperatorRector] Wip adding new rule fix #7781#3400
Closed
JohJohan wants to merge 1 commit intorectorphp:mainfrom
Closed
[CleanupUnneededNullsafeOperatorRector] Wip adding new rule fix #7781#3400JohJohan wants to merge 1 commit intorectorphp:mainfrom
JohJohan wants to merge 1 commit intorectorphp:mainfrom
Conversation
ghost
reviewed
Feb 22, 2023
rules/Php80/Rector/NullsafeMethodCall/CleanupUnneededNullsafeOperatorRector.php
Show resolved
Hide resolved
ghost
reviewed
Feb 22, 2023
rules/Php80/Rector/NullsafeMethodCall/CleanupUnneededNullsafeOperatorRector.php
Show resolved
Hide resolved
|
Fixes rectorphp/rector#7781 |
ghost
reviewed
Feb 22, 2023
rules/Php80/Rector/NullsafeMethodCall/CleanupUnneededNullsafeOperatorRector.php
Show resolved
Hide resolved
samsonasik
requested changes
Feb 22, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
This should go to CodeQuality sets
5de48ac to
0a752f7
Compare
0a752f7 to
92e4acb
Compare
|
@samsonasik i moved to |
Member
|
This looks good 👍 Thank you for your patience, as I went trough dozens of other PRs. Could you rebase and make the CI pass? I'll give it a priority now 🙂 |
Member
|
@samsonasik Could you rebase and handle this one as well? It's been opened a few months, so we can handle the changes for the @johanadivare |
Member
|
I will try 👍 |
Member
|
It has too many conflict with rebase, merge main to this branch is the way to go |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.