[CodeQuality][Printer] Handle mix php+html on TernaryFalseExpressionToIfRector#3382
Merged
TomasVotruba merged 4 commits intomainfrom Feb 15, 2023
Merged
[CodeQuality][Printer] Handle mix php+html on TernaryFalseExpressionToIfRector#3382TomasVotruba merged 4 commits intomainfrom
TomasVotruba merged 4 commits intomainfrom
Conversation
# Failing Test for TernaryFalseExpressionToIfRector Based on https://getrector.com/demo/d48f8822-9454-4055-b14c-174a6b4f2ec8 The input code makes no sense (missing echo), but is valid. Rector should not change it to invalid (fatal) code. Possible sanity check if the change results in `?> ?>` or `<?php <?php` it shouldn't apply the change but report an error right away, to make debugging rector rules faster?
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
TomasVotruba
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3376
Ref https://getrector.com/demo/d48f8822-9454-4055-b14c-174a6b4f2ec8