[TypeDeclaration] Handle nullable intersection on TypedPropertyFromAssignsRector#3372
Merged
TomasVotruba merged 9 commits intomainfrom Feb 12, 2023
Merged
Conversation
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
e68d991 to
5368ae5
Compare
Member
Author
|
@VincentLanglet @puniserv after some thinking, I think it is indeed correct, that on php 7.4, the Mock object intersection can just be skipped, even nullable, then in php 8.1, real intersection type can be applied with include nullable if applicable 👍 I applied the change so it skipped on php 7.4, and applied intersection on php 8.1, so the type will be applied when the language is actually ready. |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
|
Thanks 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3244
Fixes rectorphp/rector#7692
Use nullable MockObject on php 7.4Skip Intersection MockObject even nullable on php 7.4MockObject&TargetType=>(MockObject&TargetType)|nullon php 8.1MockObject&TargetTypeon property assigned insetUp()method on php 8.1