Fix foreach key evaluation for SimplifyForeachToArrayFilterRector. #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24de7a4 to
22ab55d
Compare
samsonasik
reviewed
Nov 27, 2022
rules/CodeQuality/Rector/Foreach_/SimplifyForeachToArrayFilterRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Nov 28, 2022
Comment on lines
143
to
148
| $parentArrayDimFetch = $keyVarUsage[0]->getAttribute(AttributeKey::PARENT_NODE); | ||
| if (! $parentArrayDimFetch instanceof ArrayDimFetch) { | ||
| return true; | ||
| } | ||
|
|
||
| return $parentArrayDimFetch->dim !== $keyVarUsage[0]; |
Member
There was a problem hiding this comment.
I tried locally, you can actually use ReadExprAnalyzer service:
Suggested change
| $parentArrayDimFetch = $keyVarUsage[0]->getAttribute(AttributeKey::PARENT_NODE); | |
| if (! $parentArrayDimFetch instanceof ArrayDimFetch) { | |
| return true; | |
| } | |
| return $parentArrayDimFetch->dim !== $keyVarUsage[0]; | |
| return ! $this->readExprAnalyzer->isExprRead(current($keyVarUsage)); |
You need to inject the constructor with Rector\ReadWrite\NodeAnalyzer\ReadExprAnalyzer service.
Member
22ab55d to
76fa681
Compare
Member
|
Thank you @Wohlie |
Contributor
Author
|
Thanks @samsonasik for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rectorphp/rector#7592
The issue rectorphp/rector#7570 can be changed to improvement, see expected result.