e2e: Add test for https://github.com/rectorphp/rector/issues/7231 #3058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You need to register new e2e dir to : rector-src/.github/workflows/e2e.yaml Line 25 in 2be958b |
Otherwise `RemovedAndAddedFilesCollector` will print something like the following and that would need to be baked into `expected-output.diff`:
[NOTE] File "/home/user/Projects/rector-src/e2e/removed-and-added-files-collector/test" will be added
24c9dc7 to
85f9d00
Compare
Currently failing when parallel running is enabled.
85f9d00 to
734da13
Compare
jtojnar
commented
Nov 12, 2022
| ]); | ||
|
|
||
| // TODO: Make it run in parallel. | ||
| $rectorConfig->disableParallel(); |
Contributor
Author
There was a problem hiding this comment.
To reproduce the failure, remove this line.
jtojnar
commented
Nov 12, 2022
| @@ -0,0 +1,6 @@ | |||
| ! [NOTE] File "./removed-and-added-files-collector/test" will be added | |||
Contributor
Author
There was a problem hiding this comment.
No idea why CI messes it up like this:
@@ @@
-! [NOTE] File
- ! "./removed-and-added-files-c
- ! ollector/test" will be added
+! [NOTE] File "./removed-and-added-files-collector/test" will be added
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.