Skip to content

[TypeDeclaration] Skip intersection array on ReturnTypeDeclarationRector on PHP 8.1 feature enabled #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 2 commits into from
Sep 22, 2022
Merged

[TypeDeclaration] Skip intersection array on ReturnTypeDeclarationRector on PHP 8.1 feature enabled #2948

TomasVotruba merged 2 commits into from
Sep 22, 2022

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 22, 2022

When on PHP 8.1 env, the following code:

final class SkipIntersectionArray
{
    public function setAuthorizationHeader(array $config): array
    {
        if (!isset($config['headers'])) {
            $config['headers'] = [];
        }

        return $config;
    }
}

produce multiple array&array type https://getrector.org/demo/aa69f911-2a43-417e-95a9-83c44178a957

This PR fix it.

Fixes rectorphp/rector#7488

@samsonasik
Copy link
Member Author

samsonasik commented Sep 22, 2022

Fixed 🎉 /cc @Aerendir @thomasschiet

@TomasVotruba TomasVotruba enabled auto-merge (squash) September 22, 2022 17:18
@TomasVotruba
Copy link
Member

TomasVotruba commented Sep 22, 2022

Thanks 👍

@TomasVotruba TomasVotruba merged commit 3335ea4 into main Sep 22, 2022
@TomasVotruba TomasVotruba deleted the skip-intersection-array branch September 22, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rector adds the same return type hint three times (array&array&array)

3 participants

@samsonasik @TomasVotruba