-
-
Notifications
You must be signed in to change notification settings - Fork 430
[Php80] Rollback preserve int key defined not start from 0 Fixture on AnnotationToAttributeRector #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
997f2b5 to
a07b46e
Compare
|
rebased. |
|
It seems cause error: There was 1 failure:
1) Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\AnnotationToAttributeRectorTest::test with data set #14 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/Doctrine/preserve_int_key_defined.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
use Doctrine\ORM\Mapping as ORM;
-#[ORM\DiscriminatorMap([1 => 'CostDetailEntity'])]
+#[ORM\DiscriminatorMap(['1' => 'CostDetailEntity'])] |
|
@TomasVotruba the the change seems make it single quoted to make CI green now e0f9d16 , compared to real integer on original PR : |
|
Fixed 🎉 by update
|
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Thank you |
Int key "1" unordered key defined is valid in Doctrine\ORM\Mapping\DiscriminatorMap per issue
that was resolved at:
It changed to string in latest PR:
This PR rollback the transformation fixture for integer unorder key fixture to avoid regression.