Skip to content

[DeadCode] Do not remove used parameter on RemoveUnusedPrivatePropertyRector #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 8 commits into from
Nov 29, 2021
Merged

[DeadCode] Do not remove used parameter on RemoveUnusedPrivatePropertyRector #1337

TomasVotruba merged 8 commits into from
Nov 29, 2021

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 29, 2021 •
edited
Loading

Given the following code:

    private PageInterface $page;
    private SectionInterface $section;

	public function __construct(PageInterface $page, SectionInterface $section)
    {
        $this->page = $page;
        $this->section = $section;

        parent::__construct($page, $section);
    }

It produce :

-    private SectionInterface $section;
 
-       public function __construct(PageInterface $page, SectionInterface $section)
+       public function __construct(PageInterface $page)
     {
         $this->page = $page;
-        $this->section = $section;

which parameter $section should not be removed as used in parent::__construct()

Fixes rectorphp/rector#6822

@samsonasik samsonasik changed the title [DeadCode] Skip used in parent::__construct() on RemoveUnusedPrivatePropertyRector [DeadCode] Do not remove used parameter on RemoveUnusedPrivatePropertyRector Nov 29, 2021
@samsonasik
Copy link
Member Author

samsonasik commented Nov 29, 2021

Fixed 🎉

@samsonasik samsonasik force-pushed the handle-remove-unused-promoted-private branch from 77ead80 to b60ebb5 Compare November 29, 2021 05:09
@samsonasik
Copy link
Member Author

samsonasik commented Nov 29, 2021

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 50bbdd1 into main Nov 29, 2021
@TomasVotruba TomasVotruba deleted the handle-remove-unused-promoted-private branch November 29, 2021 06:30
@TomasVotruba
Copy link
Member

TomasVotruba commented Nov 29, 2021

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of RemoveUnusedPromotedPropertyRector, RemoveUnusedPrivatePropertyRector

4 participants

@samsonasik @TomasVotruba @actions-user