Revert "remove unnecessary assign when possible"

samsonasik · samsonasik · commit 3026074875b8 · 2023-07-15T00:35:45.000+07:00
This reverts commit c69c8e6.
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictParamRector.php b/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictParamRector.php
@@ -85,22 +85,21 @@ public function provideMinPhpVersion(): int
      */
     public function refactorWithScope(Node $node, Scope $scope): ?Node
     {
-        if ($node->stmts === null) {
+        $stmts = $node->stmts;
+        if ($stmts === null) {
             return null;
         }
 
         if ($this->shouldSkipNode($node)) {
             return null;
         }
 
-        $return = $this->findCurrentScopeReturn($node->stmts);
+        $return = $this->findCurrentScopeReturn($stmts);
         if (! $return instanceof Return_ || ! $return->expr instanceof Expr) {
             return null;
         }
 
         $returnName = $this->getName($return->expr);
-        $stmts = $node->stmts;
-
         foreach ($node->getParams() as $param) {
             if (! $param->type instanceof Node) {
                 continue;

Original file line number	Diff line number	Diff line change
`@@ -85,22 +85,21 @@ public function provideMinPhpVersion(): int`
`85`	`85`	`*/`
`86`	`86`	`public function refactorWithScope(Node $node, Scope $scope): ?Node`
`87`	`87`	`{`
`88`		`- if ($node->stmts === null) {`
	`88`	`+ $stmts = $node->stmts;`
	`89`	`+ if ($stmts === null) {`
`89`	`90`	`return null;`
`90`	`91`	`}`
`91`	`92`
`92`	`93`	`if ($this->shouldSkipNode($node)) {`
`93`	`94`	`return null;`
`94`	`95`	`}`
`95`	`96`
`96`		`- $return = $this->findCurrentScopeReturn($node->stmts);`
	`97`	`+ $return = $this->findCurrentScopeReturn($stmts);`
`97`	`98`	`if (! $return instanceof Return_ \|\| ! $return->expr instanceof Expr) {`
`98`	`99`	`return null;`
`99`	`100`	`}`
`100`	`101`
`101`	`102`	`$returnName = $this->getName($return->expr);`
`102`		`- $stmts = $node->stmts;`
`103`		`-`
`104`	`103`	`foreach ($node->getParams() as $param) {`
`105`	`104`	`if (! $param->type instanceof Node) {`
`106`	`105`	`continue;`