Performance: Use faster hashing algo for cache key generation (#3508)

keulinho · web-flow · commit 0f0b936c98b5 · 2023-03-27T15:06:17.000+07:00
* Use faster hashing algo for cache key generation

* Use 128 bit hashing algo again
diff --git a/rules/Renaming/NodeManipulator/ClassRenamer.php b/rules/Renaming/NodeManipulator/ClassRenamer.php
@@ -452,7 +452,15 @@ private function shouldRemoveUseName(string $last, string $newNameLastName, bool
     private function createOldToNewTypes(Node $node, array $oldToNewClasses): array
     {
         $oldToNewClasses = $this->resolveOldToNewClassCallbacks($node, $oldToNewClasses);
-        $cacheKey = md5(serialize($oldToNewClasses));
+
+        // md4 is faster then md5 https://php.watch/articles/php-hash-benchmark
+        $hashingAlgorithm = 'md4';
+        if (\PHP_VERSION_ID >= 80100) {
+            // if xxh128 is available use it, as it is way faster then md4 https://php.watch/articles/php-hash-benchmark
+            $hashingAlgorithm = 'xxh128';
+        }
+
+        $cacheKey = \hash($hashingAlgorithm, \serialize($oldToNewClasses));
 
         if (isset($this->oldToNewTypesByCacheKey[$cacheKey])) {
             return $this->oldToNewTypesByCacheKey[$cacheKey];
