[DowngradePhp80] Add DowngradeInlinedAttributeRector#37
Closed
samsonasik wants to merge 3 commits intomainfrom
Closed
[DowngradePhp80] Add DowngradeInlinedAttributeRector#37samsonasik wants to merge 3 commits intomainfrom
samsonasik wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
It seems line detection is always same whether it multilne or no not, possibly need token check. |
Member
Author
|
@TomasVotruba it seems for JetBrain Language attribute, it originallly multiline, see PR: , and the php-scoper make it single lined, so there is nothing we can do except just convert it to annotation like in PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is alternative of PR:
which it re-print the node when it has same line, so attribute will still usefull when user use in php8+