Add failing test fixture for RemoveRedundantDefaultPropertyAnnotation… #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ValuesRector # Failing Test for RemoveRedundantDefaultPropertyAnnotationValuesRector Based on https://getrector.org/demo/926896fe-4d3f-4cd2-930e-be843ad5eb34
Member
|
@TomasVotruba this is related with partial value update I commented at rectorphp/rector-src#2786 (review) which next annotation is Original patch PR for it rectorphp/rector-src#1862 This needs to be patched in rector-src to verify. |
Member
|
I created PR rectorphp/rector-src#2914 for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ValuesRector
Failing Test for RemoveRedundantDefaultPropertyAnnotationValuesRector
Based on https://getrector.org/demo/926896fe-4d3f-4cd2-930e-be843ad5eb34