Skip to content

Incorrect behavior of RenameParamToMatchTypeRector #9755

Description

@samsonasik

Bug Report

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/26a991f2-35dc-4a15-95b7-67f81d95617f

<?php

use PhpParser\Node\Stmt\ClassLike;

final class DemoFile
{
	public function collectDependencies(ClassLike $node): array
    {
        $nodeTraverser = new NodeTraverser();
        $visitor       = new class extends NodeVisitorAbstract {
            public array $names = [];

            public function enterNode(Node $node): null
            {
                if ($node instanceof FullyQualified) {
                    $this->names[] = implode('\\', $node->getParts());
                }

                return null;
            }
        };

        $nodeTraverser->addVisitor($visitor);
        $nodeTraverser->traverse([$node]);
    }
}

Responsible rules

  • RenameParamToMatchTypeRector

Expected Behavior

Currently, this part is not updated:

        $nodeTraverser->addVisitor($visitor);
        $nodeTraverser->traverse([$node]);

cause error as $node is undefined.

Undefined variable: $node

This should be skipped or updated so it keep sync with param variable name.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions