Skip to content

Incorrect behavior of PrivatizeFinalClassPropertyRector #9481

@simonschaufi

Description

@simonschaufi

Bug Report

Running PrivatizeFinalClassPropertyRector looses readonly.

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/ecbe4f22-22d0-4423-b803-eafc596460c8

<?php

use TYPO3\CMS\Core\LinkHandling\LinkService;

final class DemoFile
{
    public function __construct(protected readonly LinkService $linkService)
    {
    }
}

Responsible rules

  • PrivatizeFinalClassPropertyRector

Expected Behavior

<?php

use TYPO3\CMS\Core\LinkHandling\LinkService;

final class DemoFile
{
    public function __construct(private readonly LinkService $linkService)
    {
    }
}

Actual Behavior

<?php

use TYPO3\CMS\Core\LinkHandling\LinkService;

final class DemoFile
{
    public function __construct(private LinkService $linkService)
    {
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions