Skip to content

Wrong refactor by RemoveExtraParametersRector rule #9088

@muxx

Description

@muxx

Bug Report

Subject Details
Rector version v2.0.0

In Gitlab CI we sometimes get such rector fixes:

===== rector-all
1 file with changes
===================
1) src/Intaro/CRMImportBundle/Services/Import/ProductImport.php:92
    ---------- begin diff ----------
@@ @@
                 /** @var ImportException $error */
                 foreach ($productDTO->getErrors() as $error) {
                     $message = $this->translator->trans('errors.message_property_value', [
-                        '%message%' => mb_trim($error->getMessage(), '.'),
+                        '%message%' => mb_trim(),
                         '%property%' => $error->getProperty(),
                         '%value%' => $error->getWrongValue(),
                     ]);
@@ @@
                 if (count($errors) > 0) {
                     foreach ($errors as $err) {
                         $message = $this->translator->trans('errors.message_property_value', [
-                            '%message%' => mb_trim($err->getMessage(), '.'),
+                            '%message%' => mb_trim(),
                             '%property%' => $err->getPropertyPath(),
                             '%value%' => empty($err->getInvalidValue()) ? 'NULL' : $err->getInvalidValue(),
                         ]);
    ----------- end diff -----------
Applied rules:
 * RemoveExtraParametersRector
 [OK] 1 file would have been changed (dry-run) by Rector  

Unfortunately we can not reproduce this bug locally (

Expected Behaviour

Rule should not change the target code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions