Skip to content

NodeConnectingVisitor enabled again after bleedingedge removed. #8155

@samsonasik

Description

@samsonasik

Bug Report

Subject Details
Rector version e.g. dev-main

Minimal PHP Code Causing Issue

When debugging, I found that parent, prev, and next attribute shown again:

.PhpParser\Node\Stmt\ClassMethod #42281
   flags: 9
   byRef: false
   name: PhpParser\Node\Identifier #42275
   |  name: 'dynamicContent'
   |  attributes: array (10) ...
   params: array (0)
   returnType: PhpParser\Node\Identifier #42276
   |  name: 'array'
   |  attributes: array (12) ...
   stmts: array (1)
   |  0 => PhpParser\Node\Stmt\Return_ #42280 ...
   attrGroups: array (0)
   attributes: array (13)
   |  'parent' => PhpParser\Node\Stmt\Enum_ #42282 ...
   |  'previous' => PhpParser\Node\Stmt\ClassMethod #42274 ...

It also shown on scoped rector/rector.

Expected Behaviour

It should not show the parent, previous, next. There is no enabled config in config/phpstan so it somehow enabled internally somewhere, the PHPStan config seems need update without bleedingedge:

parameters:
    # see https://github.com/rectorphp/rector/issues/3490#issue-634342324
    featureToggles:
        disableRuntimeReflectionProvider: false
+        nodeConnectingVisitorCompatibility: false

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions