Call typed defaulter for reconciled object#677
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Feb 4, 2026
Merged
Conversation
controller-runtime now encourages the use of a typed webhook methods
instead of using runtime.Object. This change in method signature was
causing the Default method to be missed during a reconcile, allowing
non-defaulted objects to be processed. It is now called when the
generic type matches the type being reconciled.
For example:
_ admission.Defaulter[*TestResource] = &TestResource{}
func (*TestResource) Default(ctx context.Context, obj *TestResource) error {
...
}
Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 60.25% 60.18% -0.08%
==========================================
Files 39 39
Lines 3628 3634 +6
==========================================
+ Hits 2186 2187 +1
- Misses 1329 1332 +3
- Partials 113 115 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
controller-runtime now encourages the use of a typed webhook methods instead of using runtime.Object. This change in method signature was causing the Default method to be missed during a reconcile, allowing non-defaulted objects to be processed. It is now called when the generic type matches the type being reconciled.
For example: