Merged
Conversation
controller-runtime is transition to a new event recorder based on the events.k8s.io Event kind rather the the core Event kind. The previous API is now deprecated, but remains available. The Config type now exposes both interfaces with the previous version also deprecated as the upstream API it depends on is deprecated in controller-runtime. To use to the new API users must add events.k8s.io Event to their RBAC permissions for the controller. Test expectations combine both the previous and new API for comparing actual and expected behavior. The new API allows referencing a related object for an event in addition to an optional human readable notes field. Both are optional. Changes to provided reconcilers to use the updated API are forthcoming. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
+ Coverage 60.04% 60.25% +0.20%
==========================================
Files 39 39
Lines 3594 3628 +34
==========================================
+ Hits 2158 2186 +28
- Misses 1325 1329 +4
- Partials 111 113 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Scott Andrews <scott@andrews.me>
mamachanko
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
controller-runtime is transition to a new event recorder based on the events.k8s.io Event kind rather the the core Event kind. The previous API is now deprecated, but remains available.
The Config type now exposes both interfaces with the previous version also deprecated as the upstream API it depends on is deprecated in controller-runtime.
To use to the new API users must add events.k8s.io Event to their RBAC permissions for the controller. Test expectations combine both the previous and new API for comparing actual and expected behavior.
The new API allows referencing a related object for an event in addition to an optional human readable notes field. Both are optional.
Changes to provided reconcilers to use the updated API are forthcoming.