Extract stash machinery into dedicated package#650
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Sep 16, 2025
Merged
Conversation
The existing types/names are aliased back into the reconcilers package to preserve compatibility. Symbol names in the new package have evolved slightly to avoid redundancy: - `StashKey` -> `Key` - `NewStasher` -> `New` - `WithStash` -> `WithContext` - `StashValue` -> `StoreValue` - `ErrStashValueNotFound` -> `ErrValueNotFound` - `ErrStashValueNotAssignable` -> `ErrValueNotAssignable` Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
- Coverage 57.34% 57.28% -0.07%
==========================================
Files 38 39 +1
Lines 4504 4507 +3
==========================================
- Hits 2583 2582 -1
- Misses 1807 1811 +4
Partials 114 114 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing types/names are aliased back into the reconcilers package to preserve compatibility.
Symbol names in the new package have evolved slightly to avoid redundancy:
StashKey->KeyNewStasher->NewWithStash->WithContextStashValue->StoreValueErrStashValueNotFound->ErrValueNotFoundErrStashValueNotAssignable->ErrValueNotAssignableResolves #591