Config WithTracker creates a new tracker for the config#626
Merged
scothis merged 1 commit intoreconcilerio:mainfrom May 7, 2025
Merged
Config WithTracker creates a new tracker for the config#626scothis merged 1 commit intoreconcilerio:mainfrom
scothis merged 1 commit intoreconcilerio:mainfrom
Conversation
Each controller should have it's own tracker, while preserving caches that are embedded within the clients. Config#WithTracker returns a new Config with a new Tracker while copying forward the other properties. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #626 +/- ##
==========================================
- Coverage 57.13% 57.02% -0.11%
==========================================
Files 37 37
Lines 4414 4426 +12
==========================================
+ Hits 2522 2524 +2
- Misses 1784 1794 +10
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each controller should have it's own tracker, while preserving caches that are embedded within the clients. Config#WithTracker returns a new Config with a new Tracker while copying forward the other properties.