Skip to content

Normalize ducks in fake client config#619

Merged
scothis merged 1 commit intomainfrom
duck-convert
Apr 10, 2025
Merged

Normalize ducks in fake client config#619
scothis merged 1 commit intomainfrom
duck-convert

Conversation

@scothis
Copy link
Member

@scothis scothis commented Apr 10, 2025

Convert typed ducks into unstructured objects for given resourcse and status subresources. This means test authors can use typed ducks rather than unstructured objects.

Defined a generic Convert method to convert an object between two types. Data will only be preserved between fields that have a common shape, dropping undefined fields.

Convert typed ducks into unstructured objects for given resourcse and
status subresources. This means test authors can use typed ducks rather
than unstructured objects.

Defined a generic Convert method to convert an object between two types.
Data will only be preserved between fields that have a common shape,
dropping undefined fields.

Signed-off-by: Scott Andrews <scott@andrews.me>
@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 36 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (95091cf) to head (cec1da5).

Files with missing lines Patch % Lines
duck/client.go 18.42% 27 Missing and 4 partials ⚠️
testing/config.go 64.28% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   59.29%   59.32%   +0.03%     
==========================================
  Files          36       36              
  Lines        4213     4224      +11     
==========================================
+ Hits         2498     2506       +8     
  Misses       1605     1605              
- Partials      110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scothis scothis merged commit a8e006d into main Apr 10, 2025
4 of 5 checks passed
@scothis scothis deleted the duck-convert branch April 10, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant