Skip to content

Allow ducks to own child resources#615

Merged
scothis merged 2 commits intoreconcilerio:mainfrom
scothis:duck-owners
Apr 10, 2025
Merged

Allow ducks to own child resources#615
scothis merged 2 commits intoreconcilerio:mainfrom
scothis:duck-owners

Conversation

@scothis
Copy link
Member

@scothis scothis commented Apr 9, 2025

The utility to set a controlling owner reference for a child resource was not duck aware causing an error. Now it is.

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 37.14286% with 44 lines in your changes missing coverage. Please review.

Project coverage is 59.29%. Comparing base (ab3c29b) to head (7d92ec6).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
reconcilers/child.go 37.14% 34 Missing and 10 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   59.65%   59.29%   -0.36%     
==========================================
  Files          36       36              
  Lines        4144     4213      +69     
==========================================
+ Hits         2472     2498      +26     
- Misses       1571     1605      +34     
- Partials      101      110       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The utility to set a controlling owner reference for a child resource
was not duck aware causing an error. Now it is.

Signed-off-by: Scott Andrews <scott@andrews.me>
Signed-off-by: Scott Andrews <scott@andrews.me>
@scothis scothis marked this pull request as ready for review April 9, 2025 19:23
@scothis scothis requested a review from mamachanko April 9, 2025 19:23
Copy link
Contributor

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍

@scothis scothis merged commit 95091cf into reconcilerio:main Apr 10, 2025
2 of 4 checks passed
@scothis scothis deleted the duck-owners branch April 10, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants