Suppress result when updating status#609
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Mar 27, 2025
Merged
Conversation
Updating the status for a resource will propagated from the api server back to the informer causing the resource be added to the queue. Directly requesting a requeue is counter productive because we may end up reprocessing the now stale resource. Worse, requeues will extend the work queue backoff while it should be reset. We now always return an empty result after updating the status. The resource is reprocessed organically. ErrSkipStatusUpdate allows a sub reconciler to opt out of the status update even if the value has changed. As an error, the request is requeued automatically. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 59.42% 59.43%
=======================================
Files 36 36
Lines 4101 4102 +1
=======================================
+ Hits 2437 2438 +1
Misses 1566 1566
Partials 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamachanko
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the status for a resource will propagated from the api server back to the informer causing the resource be added to the queue. Directly requesting a requeue is counter productive because we may end up reprocessing the now stale resource. Worse, requeues will extend the work queue backoff while it should be reset.
We now always return an empty result after updating the status. The resource is reprocessed organically.
ErrSkipStatusUpdate allows a sub reconciler to opt out of the status update even if the value has changed. As an error, the request is requeued automatically.