Skip to content

Always reconciler#607

Merged
scothis merged 1 commit intoreconcilerio:mainfrom
scothis:always
Mar 24, 2025
Merged

Always reconciler#607
scothis merged 1 commit intoreconcilerio:mainfrom
scothis:always

Conversation

@scothis
Copy link
Member

@scothis scothis commented Mar 24, 2025

Always is a collection of SubReconcilers called in order. Each reconciler is called regardless of previous errors. The resulting errors are joined. The resulting joined error will only match ErrQuiet if all contributing errors match ErrQuiet.

Always is identical to Sequence, except for error handling.

Always is a collection of SubReconcilers called in order. Each
reconciler is called regardless of previous errors. The resulting errors
are joined. The resulting joined error will only match ErrQuiet if all
contributing errors match ErrQuiet.

Always is identical to Sequence, except for error handling.

Signed-off-by: Scott Andrews <scott@andrews.me>
@scothis scothis requested a review from mamachanko March 24, 2025 02:46
@scothis scothis marked this pull request as ready for review March 24, 2025 02:46
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 72.50000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 59.28%. Comparing base (d0110d3) to head (bd7e098).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
reconcilers/always.go 72.50% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
+ Coverage   59.15%   59.28%   +0.13%     
==========================================
  Files          35       36       +1     
  Lines        4047     4087      +40     
==========================================
+ Hits         2394     2423      +29     
- Misses       1555     1566      +11     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@scothis scothis merged commit b3fc209 into reconcilerio:main Mar 24, 2025
4 checks passed
@scothis scothis deleted the always branch March 24, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants