Quiet errors are always actually quiet#605
Merged
scothis merged 2 commits intoreconcilerio:mainfrom Mar 17, 2025
Merged
Conversation
controller-runtime will always log an error returned it it from a reconciler. In order to avoid the quieted errors from appearing in the logs, we need to return a nil error. To get the same effect of an error without the logging, we also request a requeue. The requeue is handled the same as if the request erred in terms of the workqueue backoffs. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 59.25% 59.15% -0.10%
==========================================
Files 35 35
Lines 4032 4047 +15
==========================================
+ Hits 2389 2394 +5
- Misses 1547 1555 +8
- Partials 96 98 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mamachanko
approved these changes
Mar 17, 2025
Co-authored-by: Max Brauer <mamachanko@users.noreply.github.com> Signed-off-by: Scott Andrews <scott@andrews.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
controller-runtime will always log an error returned to it from a reconciler. In order to avoid the quieted errors from appearing in the logs, we need to return a nil error. To get the same effect of an error without the logging, we also request a requeue. The requeue is handled the same as if the request erred in terms of the workqueue backoffs.