Validate AdmissionWebhookAdapter#597
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Feb 19, 2025
Merged
Conversation
Defines and calls Validate() on AdmissionWebhookAdapter when building the webhook. Calls validate with nested validation inside AdmissionWebhookTestCase. AdmissionWebhookAdapter#Build is now deprecated in favor of AdmissionWebhookAdapter#BuildWithContext which accepts a context and returns an error when validation fails. The previous Build will use a TODO context and panic on validation errors. AdmissionWebhookTestSuite#Run, AdmissionWebhookTests#Run, and AdmissionWebhookTestCase#Run are deprecated in favor of RunWithContext. The existing Run method delegates to RunWithContext, but requires users to manually configure nested validation (if desired). Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 59.35% 59.25% -0.11%
==========================================
Files 35 35
Lines 3981 4032 +51
==========================================
+ Hits 2363 2389 +26
- Misses 1522 1547 +25
Partials 96 96 ☔ View full report in Codecov by Sentry. |
mamachanko
approved these changes
Feb 19, 2025
Contributor
mamachanko
left a comment
There was a problem hiding this comment.
I had just started to work on this 😆 main...mamachanko:reconcilerio-runtime:topic/mamachanko/main/validate-webhooks, but I ran into the problems you solved with BuildWithContext.
This is excellent! ty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines and calls Validate() on AdmissionWebhookAdapter when building the webhook. Calls validate with nested validation inside AdmissionWebhookTestCase.
AdmissionWebhookAdapter#Build is now deprecated in favor of AdmissionWebhookAdapter#BuildWithContext which accepts a context and returns an error when validation fails. The previous Build will use a TODO context and panic on validation errors.
AdmissionWebhookTestSuite#Run, AdmissionWebhookTests#Run, and AdmissionWebhookTestCase#Run are deprecated in favor of RunWithContext. The existing Run method delegates to RunWithContext, but requires users to manually configure nested validation (if desired).
Follow up to #583