Allow ChildReconciler to choose which errors to reflect#579
Merged
scothis merged 2 commits intoreconcilerio:mainfrom Jan 28, 2025
Merged
Allow ChildReconciler to choose which errors to reflect#579scothis merged 2 commits intoreconcilerio:mainfrom
scothis merged 2 commits intoreconcilerio:mainfrom
Conversation
A ChildReconciler can affirmatively select which errors to pass to ReflectChildStatusOnParent by defining ReflectedChildErrorReasons. Like before, reflecting errors is like a catch. Errors not reflected are returned by the ChildReconciler so the reconcile request can be retried. Handled error reasons are not returned. By default, StatusReasonForbidden is now included along with the previous StatusReasonAlreadyExists and StatusReasonInvalid. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
==========================================
+ Coverage 58.25% 58.33% +0.08%
==========================================
Files 33 33
Lines 3787 3795 +8
==========================================
+ Hits 2206 2214 +8
Misses 1487 1487
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Scott Andrews <scott@andrews.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ChildReconciler can affirmatively select which errors to pass to ReflectChildStatusOnParent by defining ReflectedChildErrorReasons. Like before, reflecting errors is like a catch. Errors not reflected are returned by the ChildReconciler so the reconcile request can be retried. Handled error reasons are not returned.
By default, StatusReasonForbidden is now included along with the previous StatusReasonAlreadyExists and StatusReasonInvalid.