fix: stop using deprecated webhook.Validator and webhook.Defaulter#575
Merged
scothis merged 2 commits intoreconcilerio:mainfrom Jan 17, 2025
Conversation
fixes reconcilerio#574 Signed-off-by: Max Brauer <mbrauer@vmware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #575 +/- ##
=======================================
Coverage 58.25% 58.25%
=======================================
Files 33 33
Lines 3787 3787
=======================================
Hits 2206 2206
Misses 1487 1487
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Member
|
Thanks for starting this. While the Defaulter interface has now been removed upstream, I'd like to keep support for it here as removing it can lead to subtile bugs that are hard to diagnose. I'll add a commit to restore the support in this PR. |
The webhook.Defaulter interface has been removed upstream, but we should continue to support the Default() method when reconciling a resource. Removing support for this method can lead to subtile bugs that are difficult to track down. Signed-off-by: Scott Andrews <scott@andrews.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #574