Track colliding child resources that are not owned#569
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Jan 3, 2025
Merged
Track colliding child resources that are not owned#569scothis merged 1 commit intoreconcilerio:mainfrom
scothis merged 1 commit intoreconcilerio:mainfrom
Conversation
When creating a child resource with a fixed name, it's possible there is already a resource with the same that that will block the creation of the new resource. If this resource isn't owned by our resource and owner relationship are utilized that creates a blind spot where changes to that resource will not trigger a new reconcile. We now track resources in this very specific case. When the target child resource is deleted the parent resource will now be reconciled. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 58.22% 58.25% +0.02%
==========================================
Files 33 33
Lines 3782 3787 +5
==========================================
+ Hits 2202 2206 +4
- Misses 1486 1487 +1
Partials 94 94 ☔ View full report in Codecov by Sentry. |
mamachanko
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a child resource with a fixed name, it's possible there already exists a resource with the same name that blocks the creation of the new resource. If this resource isn't owned by our resource (and owner relationships are utilized) that creates a blind spot where changes to that resource will not trigger a new reconcile.
We now track resources in this very specific case. When the target child resource is deleted the parent resource will now be reconciled.