Drop deprecated ResourceManager APIs#549
Merged
scothis merged 2 commits intoreconcilerio:mainfrom Oct 4, 2024
Merged
Conversation
Signed-off-by: Scott Andrews <scott@andrews.me>
Previously tests for the ResourceManager were bound to the ChildReconciler from before ResourceManager was split from ChildReconciler. The ObjectManagerReconcilerTestHarness provides a way to focus tests on just the ObjectManager's behavior. Signed-off-by: Scott Andrews <scott@andrews.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 59.83% 58.93% -0.90%
==========================================
Files 32 33 +1
Lines 2958 2981 +23
==========================================
- Hits 1770 1757 -13
- Misses 1094 1130 +36
Partials 94 94 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops deprecated APIs for
ResourceManager, and migrates tests from theChildReconcilerto theUpdatingObjectManager. This was a holdover from beforeResouceManagerwas extracted fromChildReconciler.The
StubObjectManageris useful for testing a reconciler that needs to interact with anObjectManager. It will preform a basic create/update/delete and nothing else.The
ObjectManagerReconcilerTestHarnessis useful for testing a customObjectManagerin the context of a reconciler test case. The actual, expected and result objects are stored in the reconciler stash.