ResourceManager -> ObjectManager#548
Merged
scothis merged 3 commits intoreconcilerio:mainfrom Oct 1, 2024
Merged
Conversation
The ResourceManager type is split into an interface (ObjectManager) and
implementing struct (UpdatingObjectManager).
Backwards compatibility is preserved with a number of deprecations,
including:
- `ResourceManager` is deprecated in favor of `ObjectManager` for a
generic type, or `UpdatingObjectManager`.
- `AggregateReconciler.{HarmonizeImmutableFields, MergeBeforeUpdate,
Sanitize}` are deprecated in favor of `AggregateReconciler.
AggregateObjectManager`.
- `ChildReconciler.{Finalizer, HarmonizeImmutableFields,
MergeBeforeUpdate, Sanitize, SetResourceManager}` are deprecated in
favor of `ChildReconciler.ChildObjectManager`.
- `ChildSetReconciler.{HarmonizeImmutableFields, MergeBeforeUpdate,
Sanitize}` are deprecated in favor of `ChildSetReconciler.
ChildObjectManager`.
Other strategies can be provided in the future, like replacing Update()
calls with server-side apply.
Signed-off-by: Scott Andrews <scott@andrews.me>
Member
Author
|
@mamachanko ready for review. Keeping as draft until I can test with more existing controllers to ensure compatibility. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
- Coverage 60.60% 59.83% -0.77%
==========================================
Files 32 32
Lines 2924 2958 +34
==========================================
- Hits 1772 1770 -2
- Misses 1057 1094 +37
+ Partials 95 94 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Scott Andrews <scott@andrews.me>
475be42 to
f4d3160
Compare
mamachanko
approved these changes
Oct 1, 2024
Signed-off-by: Scott Andrews <scott@andrews.me>
a6bc711 to
fe78605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ResourceManager type is split into an interface (ObjectManager) and implementing struct (UpdatingObjectManager).
AggregateReconciler, ChildReconciler and ChildSetReconciler are updated to allow specifying an alternative strategy with fallbacks to the previous behavior.
Backwards compatibility is preserved with a number of deprecations, including:
ResourceManageris deprecated in favor ofObjectManagerfor a generic type, orUpdatingObjectManager.AggregateReconciler.{HarmonizeImmutableFields, MergeBeforeUpdate, Sanitize}are deprecated in favor ofAggregateReconciler. AggregateObjectManager.ChildReconciler.{Finalizer, HarmonizeImmutableFields, MergeBeforeUpdate, Sanitize, SetResourceManager}are deprecated in favor ofChildReconciler.ChildObjectManager.ChildSetReconciler.{HarmonizeImmutableFields, MergeBeforeUpdate, Sanitize}are deprecated in favor ofChildSetReconciler. ChildObjectManager.Other strategies can be provided in the future, like replacing Update() calls with server-side apply.