feat: remove deprecated SafeDeployDiff#504
Merged
scothis merged 1 commit intoreconcilerio:mainfrom Mar 28, 2024
Merged
Conversation
scothis
approved these changes
Mar 28, 2024
Member
scothis
left a comment
There was a problem hiding this comment.
Assuming the test failure is fixed
BREAKING CHANGE: removes depracted SafeDeployDiff use reconcilers.IgnoreAllUnexported instead Signed-off-by: Max Brauer <mbrauer@vmware.com>
e540237 to
ab32a88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
=======================================
Coverage 61.13% 61.13%
=======================================
Files 28 28
Lines 2583 2583
=======================================
Hits 1579 1579
Misses 917 917
Partials 87 87 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes depracted SafeDeployDiff use reconcilers.IgnoreAllUnexported instead