Skip to content

Fix story#7154

Merged
PavelVanecek merged 1 commit intomainfrom
fix-story
Mar 22, 2026
Merged

Fix story#7154
PavelVanecek merged 1 commit intomainfrom
fix-story

Conversation

@PavelVanecek
Copy link
Copy Markdown
Collaborator

@PavelVanecek PavelVanecek commented Mar 22, 2026 •
edited by coderabbitai bot
Loading

Description

#7146 fixed a bug where the XAxis was ignoring data defined in both chart and graphical item. One of our stories did just that: https://www.chromatic.com/test?appId=63da8268a0da9970db6992aa&id=69bf5ed7116eb6d0d637ed0d so here is a fix.

Summary by CodeRabbit

  • Documentation
    • Refreshed sample datasets in the Tooltip story to showcase updated data structures.
    • Enhanced axis configuration examples in tooltip documentation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 79b45838-7094-4503-9432-7c2734e814a2

📥 Commits

Reviewing files that changed from the base of the PR and between 03df01a and a3f0b3a.

📒 Files selected for processing (1)
  • storybook/stories/Examples/Tooltip.stories.tsx

Walkthrough

Updated sample chart datasets in the SeparateDataSetsForChart Storybook story by remapping data categories from B/C/D to C/D/E/F and added the allowDuplicatedCategory={false} prop to the XAxis component.

Changes

Cohort / File(s) Summary
Storybook Tooltip Story
storybook/stories/Examples/Tooltip.stories.tsx		 Updated areaData and lineData sample datasets with remapped category values (B/C/D → C/D/E/F). Added allowDuplicatedCategory={false} prop to XAxis component in SeparateDataSetsForChart story.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested reviewers

  • ckifer
🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides context via external PR links but lacks detail on what specific changes were made; most required template sections are missing or incomplete. Complete the template by adding details under Motivation and Context, How Has This Been Tested, Types of changes, and the Checklist sections to document the fix comprehensively.
Title check ❓ Inconclusive The title 'Fix story' is vague and generic, failing to convey which story or what specific issue is being fixed in the changeset. Use a more descriptive title that specifies which story is being fixed and why, such as 'Fix SeparateDataSetsForChart story to work with XAxis duplicated category fix'.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-story

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2026

Bundle Report

Bundle size has no change ✅

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 22, 2026

Staging Deployment Details

These deployments will remain available for 30 days.

To update snapshots: Comment /update-snapshots on this PR to automatically update the baseline screenshots.

@PavelVanecek PavelVanecek merged commit 5f9f3e8 into main Mar 22, 2026
56 of 57 checks passed
@PavelVanecek PavelVanecek deleted the fix-story branch March 22, 2026 04:38
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (03df01a) to head (a3f0b3a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7154   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         536      536           
  Lines       40480    40480           
  Branches     5521     5521           
=======================================
  Hits        36282    36282           
  Misses       4190     4190           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PavelVanecek