test/cartesian/Bar.truncateByDomain.spec.tsx (1)

155-205: Use expectLastCalledWith in this modified selector assertion block.

This block was touched and still uses toHaveBeenLastCalledWith, which diverges from the test helper convention used elsewhere.

Suggested update

 import { describe, expect, it, test } from 'vitest';
 import { createSelectorTestCase } from '../helper/createSelectorTestCase';
+import { expectLastCalledWith } from '../helper/expectLastCalledWith';
@@
-      expect(spy).toHaveBeenLastCalledWith({
+      expectLastCalledWith(spy, {
         date: {
           graphicalItems: [
@@
-      });
+      });

As per coding guidelines: Use the `expectLastCalledWith` helper function instead of `expect(spy).toHaveBeenLastCalledWith(...)` for better typing and autocompletion.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/cartesian/Bar.truncateByDomain.spec.tsx` around lines 155 - 205, The
test 'selectStackGroups' currently calls
expect(spy).toHaveBeenLastCalledWith(...) — update this assertion to use the
project test-helper expectLastCalledWith helper instead; locate the test block
that invokes selectStackGroups and replace the
expect(spy).toHaveBeenLastCalledWith call with a call to
expectLastCalledWith(spy, <same expected object>) so the assertion uses the
helper while keeping the same expected payload (references: test name
'selectStackGroups', selector function 'selectStackGroups', and the local 'spy'
variable).

src/cartesian/Bar.tsx (1)

1116-1122: Narrow custom-shape detection to actual custom renderers.

Line 1185 marks any non-null shape as custom, which can disable zero-dimension filtering more broadly than necessary. Consider flagging only function/element shapes so optimization stays active for default-rectangle variants.

Proposed refinement

 function BarFn(outsideProps: Props) {
   const props = resolveDefaultProps(outsideProps, defaultBarProps);
+  const hasCustomShape = React.isValidElement(props.shape) || typeof props.shape === 'function';
   // stackId may arrive from props or from BarStack context
   const stackId = useStackId(props.stackId);
   const isPanorama = useIsPanorama();
@@
-            hasCustomShape={props.shape != null}
+            hasCustomShape={hasCustomShape}
           />

Also applies to: 1185-1185

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/cartesian/Bar.tsx` around lines 1116 - 1122, The guard that skips
zero-dimension filtering uses hasCustomShape derived from a non-null check on
shape; change the detection in the Bar component so hasCustomShape is set only
when shape is an actual custom renderer (e.g., typeof shape === 'function' or
React.isValidElement(shape) / React.isValidElement-like check) instead of any
non-null value, so the early-return condition in the null/zero check (the if
block referencing x, y, width, height and hasCustomShape) continues to filter
out width===0/height===0 for default rectangle shapes but allows true custom
renderers to bypass it.

test/cartesian/Bar.zeroDimensionFiltering.spec.tsx (1)

272-307: Add a DOM assertion for rendered marker lines, not only selector output.

Great selector-level check. I’d also assert the custom shape is actually rendered to guard the visual regression end-to-end.

Suggested extension

   it('should not filter out zero-height bars that have a custom shape (BoxPlot use case)', () => {
     const HorizonBar = (props: { x?: number; y?: number; width?: number; height?: number }) => {
       const { x, y, width } = props;
       if (x == null || y == null || width == null) {
         return null;
       }
-      return <line x1={x} y1={y} x2={x + width} y2={y} stroke="#000" strokeWidth={3} />;
+      return <line className="horizon-marker" x1={x} y1={y} x2={x + width} y2={y} stroke="#000" strokeWidth={3} />;
     };
@@
-    const { spy } = renderTestCase(state => selectBarRectangles(state, 'bar-marker', false, undefined));
+    const { container, spy } = renderTestCase(state => selectBarRectangles(state, 'bar-marker', false, undefined));
     const rectangles = spy.mock.lastCall?.[0] ?? [];
@@
     rectangles.forEach((rect: { height: number }) => {
       expect(rect.height).toBe(0);
     });
+    expect(container.querySelectorAll('.horizon-marker')).toHaveLength(data.length);
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/cartesian/Bar.zeroDimensionFiltering.spec.tsx` around lines 272 - 307,
The test currently only asserts selector output (selectBarRectangles) for the
custom HorizonBar but doesn't verify the DOM rendering; update the spec to also
query the rendered output from renderTestCase (the BarChart with Bar id
"bar-marker" and shape HorizonBar) and assert that the expected <line> elements
for each data row are present and have the expected attributes (e.g., y/x/width
or stroke/strokeWidth) so the custom shape is actually rendered end-to-end; use
the same renderTestCase helper to get the rendered container and
querySelectorAll('line') (or a scoped selector) and assert its length equals
data.length and attribute values match the marker positions.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro