Update niceTicks to enum, add support for nice log and symlog scale ticks#7042
Update niceTicks to enum, add support for nice log and symlog scale ticks#7042PavelVanecek merged 11 commits intomainfrom
Conversation
Bundle ReportChanges will increase total bundle size by 14.06kB (0.28%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: recharts/bundle-treeshaking-treemapAssets Changed:
view changes for bundle: recharts/bundle-treeshaking-polarAssets Changed:
view changes for bundle: recharts/bundle-cjsAssets Changed:
view changes for bundle: recharts/bundle-treeshaking-sunburstAssets Changed:
view changes for bundle: recharts/bundle-es6Assets Changed:
view changes for bundle: recharts/bundle-treeshaking-sankeyAssets Changed:
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7042 +/- ##
==========================================
- Coverage 90.20% 89.80% -0.41%
==========================================
Files 526 529 +3
Lines 39650 39883 +233
Branches 5442 5446 +4
==========================================
+ Hits 35768 35815 +47
- Misses 3873 4059 +186
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
There was a problem hiding this comment.
This one I did not mean to touch but the change looks like an improvement for me so I kept it. I couldn't find any related issues.
There was a problem hiding this comment.
Chromium renders different ticks than the other two browsers which is interesting I suppose. At least it's consistent.
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
35704e2 to
1067efc
Compare
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
1067efc to
16fd6e2
Compare
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
…enum Co-authored-by: PavelVanecek <1100170+PavelVanecek@users.noreply.github.com>
…enum Co-authored-by: PavelVanecek <1100170+PavelVanecek@users.noreply.github.com>
…enum Co-authored-by: PavelVanecek <1100170+PavelVanecek@users.noreply.github.com>
16fd6e2 to
f782614
Compare
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
Okay so I added couple changes here on my own:
nicecTicksfrom boolean to enum ('adaptive' | 'snap125') - let me know if you can think of better namesSee https://recharts.github.io/recharts/pr-7042/www/en-US/guide/axisTicks/
NiceTickstype:'none' | 'auto' | 'equidistant' | 'nice'incartesianAxisSlice.tsTicksSettings.niceTicksfrombooleantoNiceTickscombineNiceTicksinaxisSelectors.tsto handle enum valuesfalse→'auto'in all axis settings and default props filesXAxis.tsx,YAxis.tsx,PolarAngleAxis.tsx,PolarRadiusAxis.tsxNiceTickstype fromsrc/index.tsniceTicks: falseto useniceTicks: 'auto''none','equidistant', and'nice'enum valuesNiceTicksstorybook story for visual documentationNiceTicksto theexportsThatNeedExampleslist inverifyExamples.spec.tswww/example components usingniceTicks(boolean shorthand) →niceTicks="nice"Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.