.github/workflows/ci.yml (2)

175-183: BundleWatch step is not guarded — transient failures will block Chromatic publishing.

Unlike the Chromatic step (which has if: ${{ env.ENCRYPTED_CHROMATIC_TOKEN }}), the BundleWatch step has no continue-on-error: true and no guard condition. Any BundleWatch failure — including service outages, upstream API errors, or a stale BUNDLEWATCH_GITHUB_TOKEN — will fail the whole build_test_pack job and prevent Chromatic from publishing.

If the intent is for bundle size regressions to be hard-blocking, this is fine. But consider adding continue-on-error: true (at least initially while baselining) so that infrastructure issues don't cascade into blocking the rest of the job.

💡 Suggested guard pattern (optional)

      - name: BundleWatch
+       continue-on-error: true
        env:
          BUNDLEWATCH_GITHUB_TOKEN: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 175 - 183, The BundleWatch step named
"BundleWatch" is currently unguarded and can fail the entire build_test_pack
job; update that workflow step to either add continue-on-error: true to the
BundleWatch step or add a guard condition (e.g., only run when
BUNDLEWATCH_GITHUB_TOKEN is present) so transient BundleWatch failures do not
block Chromatic publishing—locate the step that sets BUNDLEWATCH_GITHUB_TOKEN
and run: npm run bundlewatch and add the chosen guard (continue-on-error or an
if: check) to that step.

---

175-183: Add explicit step dependency or pre-check for bundlewatch-bundles files.

The BundleWatch step (lines 175-183) implicitly depends on bundlewatch-bundles/treeshaking-*.js files created by the "Upload bundle analysis report to Codecov" step, but there is no explicit needs: clause. Additionally, error handling in scripts/upload-bundle-analysis.js swallows failures: the .catch() at line 36 logs errors without rethrowing, so if the promise chain exits early (e.g., before all five fs.copyFileSync calls at line 118), BundleWatch will silently find missing files or report 0 bytes without a clear diagnostic.

Clarify this coupling by adding an explicit needs: dependency in the workflow, or add a pre-check in the BundleWatch step to verify the expected files exist.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 175 - 183, The BundleWatch job
currently implicitly depends on artifacts produced by the "Upload bundle
analysis report to Codecov" step and should either declare that dependency or
perform a pre-check; update the workflow so the BundleWatch step (name:
BundleWatch) includes an explicit needs: reference to the job that runs
scripts/upload-bundle-analysis.js, or add a pre-check before running npm run
bundlewatch that validates the presence of bundlewatch-bundles/treeshaking-*.js
files and fails fast with a clear message if any are missing; also update
scripts/upload-bundle-analysis.js to stop swallowing errors by removing the
top-level .catch() that only logs and instead rethrow or propagate the error (so
failures during fs.copyFileSync calls cannot silently leave missing files).