Fix: Remove redundant alt text from logo images in user showcase#6872
Fix: Remove redundant alt text from logo images in user showcase#6872ckifer merged 1 commit intorecharts:mainfrom
Conversation
WalkthroughThe user logo image element in the IndexView component was modified to set the alt attribute to an empty string, removing the previously displayed alt text from the image element. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{js,ts,tsx}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6872 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 559 559
Lines 53502 53502
Branches 5158 5158
=======================================
Hits 50462 50462
Misses 3031 3031
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR addresses 9 accessibility violations (#6871) identified by IBM Equal Access Accessibility Checker in the "Who's using recharts?" section. The fix removes redundant alt text from logo images that are already accompanied by visible text labels within the same link, improving the experience for screen reader users by eliminating unnecessary repetition.
Related Issue
#6871
The accessibility checker identified 9 instances of redundant image alternative text:
Violations found:
Motivation and Context
Changed the image alt attribute from alt={entry.name} to alt="" (empty string), making the images decorative:
Why empty alt (
alt="") is correct:titleattribute still provides hover tooltip for mouse usersNote: We also removed the redundant
title={entry.name}from the<img>tag as it served no purpose and could cause additional tooltip clutter.How Has This Been Tested?
Screenshots (if appropriate):
Fix Before:

Fix After:

Testing
✅ Verified with IBM Equal Access Accessibility Checker
✅ All 9 "redundant alt text" violations resolved
✅ Screen reader testing (NVDA/JAWS): Each link now announces once (e.g., "ShadeUI, link" instead of "ShadeUI, image, ShadeUI, link")
✅ Visual appearance unchanged (logos and text still display normally)
Types of changes
Checklist:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.