Reviewing files that changed from the base of the PR and between b086656 and b9fdefa.

• src/cartesian/Area.tsx (2 hunks)
• src/cartesian/Line.tsx (2 hunks)
• src/component/ActivePoints.tsx (5 hunks)
• src/state/keyboardEventsMiddleware.ts (2 hunks)
• src/state/selectors/combiners/combineActiveTooltipIndex.ts (2 hunks)
• src/state/selectors/selectors.ts (3 hunks)
• src/state/selectors/tooltipSelectors.ts (1 hunks)
• storybook/stories/Examples/LineChart/LineChart.stories.tsx (1 hunks)
• test/component/Tooltip/ActiveDot.spec.tsx (2 hunks)

storybook/stories/Examples/LineChart/LineChart.stories.tsx (1)

1141-1188: LGTM! Well-structured test story for domain-exclusion behavior.

The story effectively demonstrates the fix: when both data points lie outside the visible domain [1.01, 1.15], the tooltip and active dot are properly suppressed regardless of allowDataOverflow.

src/state/selectors/tooltipSelectors.ts (1)

395-398: LGTM! Selector dependencies properly extended for domain-aware filtering.

The addition of selectTooltipAxisDataKey and selectTooltipAxisDomain as dependencies enables domain-based validation of tooltip indices, which is essential for preventing tooltips from displaying outside the visible domain.

src/cartesian/Area.tsx (2)

631-631: LGTM! ClipPath calculation correctly mirrors dot clipping logic.

The conditional clipPath URL construction properly handles both clipDot cases, aligning active point clipping with the chart's clip region.

---

653-668: LGTM! ClipPath propagated to both main and baseline ActivePoints.

The implementation correctly passes the computed activePointsClipPath to both the main points (line 658) and the baseline points for range areas (line 666), ensuring consistent clipping behavior across all active points.

src/cartesian/Line.tsx (2)

580-580: LGTM! ClipPath calculation consistent with Area component.

The conditional clipPath URL construction properly differentiates between clipped and non-clipped dot scenarios, maintaining consistency with the existing clipping infrastructure.

---

610-616: LGTM! ClipPath correctly propagated to ActivePoints.

The activePointsClipPath is properly passed to the ActivePoints component, enabling domain-aware clipping of active dots in Line charts.

test/component/Tooltip/ActiveDot.spec.tsx (1)

279-306: LGTM! Comprehensive test validates domain-exclusion behavior.

The test properly verifies that when all data points fall outside the visible X-axis domain, the active dot and cursor are suppressed while the tooltip wrapper remains in the DOM (but not visible). Testing both allowDataOverflow values ensures the fix works consistently.

src/component/ActivePoints.tsx (2)

21-79: LGTM! ClipPath prop cleanly threaded through ActivePoint.

The optional clipPath prop is properly added to the component signature and forwarded to the Layer wrapper, enabling clipping when provided while maintaining backward compatibility.

---

94-125: LGTM! ClipPath prop properly propagated in ActivePoints.

The clipPath prop is correctly accepted in ActivePointsProps, received in the component function, and forwarded to the ActivePoint child component, completing the prop threading chain.

src/state/keyboardEventsMiddleware.ts (1)

36-45: LGTM! Domain-aware keyboard navigation properly implemented.

The middleware now respects axis domain constraints when resolving tooltip indices. The null-handling logic correctly defaults to -1 when the resolved index is null (indicating data is outside the domain), and the early exit prevents invalid keyboard navigation operations.

src/state/selectors/combiners/combineActiveTooltipIndex.ts (4)

7-17: LGTM! Robust type coercion for domain validation.

The toFiniteNumber helper properly handles numbers, Dates, and parseable values, returning undefined for non-finite results, which enables safe numeric domain comparisons.

---

19-31: LGTM! Correct numeric domain boundary checking.

The function properly normalizes domain bounds (handling reversed domains with Math.min/Math.max) and performs inclusive boundary checks, returning false when any value is non-finite.

---

79-119: LGTM! Domain-aware index resolution with proper null handling.

The function correctly:

• Clamps the desired index to valid bounds
• Returns the clamped index if no entry exists at that position
• Validates the entry against the domain and returns null when outside bounds
• Returns the stringified index when validation passes

This ensures tooltips and active dots only display when data points fall within the visible domain.

---

33-77: Based on my verification of the code through the search results, I can now assess the review comment.

The logic is sound and intentional.

Looking at the function isValueWithinDomain in the provided snippet:

1. Lines 47-49 (Array length !== 2): Returning true for arrays with length !== 2 is correct. This allows categorical domains (which can be any length > 2) to fall through to the .some() check below, where they're compared for exact matches or numeric equality. This is intentional behavior.

2. Lines 54-63 (Numeric domain bounds): The logic checks if both bounds are numeric and within range via isValueWithinNumberDomain. If either bound is null/undefined, it returns true (no filtering). This is a permissive approach for partial domains, which appears intentional for handling incomplete or auto-calculated domains.

3. Lines 65-76 (Categorical fallback): The .some() check correctly handles both exact value matches and numeric equality when the numeric conversion is possible.

The function handles edge cases appropriately:

• Undefined/null inputs early return
• Non-numeric domain values gracefully fall back to equality checks
• Partial numeric domains (with null bounds) skip filtering
• Mixed categorical/numeric comparisons are supported

src/state/selectors/selectors.ts (2)

28-28: LGTM! Import addition is correct.

The new import selectTooltipAxisDomain is properly sourced and used in the selectActiveIndex selector below.

---

92-94: Domain-aware filtering correctly implemented in combineActiveTooltipIndex.

The function properly validates that the clamped active index's corresponding entry lies within the specified domain before returning it. When outside domain bounds, it returns null to prevent tooltip display. The implementation handles both numeric ranges and categorical domains with comprehensive null-safety checks.

Reviewing files that changed from the base of the PR and between b9fdefa and 9f21cb1.

• src/state/selectors/combiners/combineActiveTooltipIndex.ts (2 hunks)
• test/state/selectors/combiners/combineActiveTooltipIndex.spec.ts (1 hunks)

src/state/selectors/combiners/combineActiveTooltipIndex.ts (4)

4-6: LGTM! Imports are appropriate.

The new imports support the domain-aware filtering logic and are all utilized in the implementation.

---

8-18: LGTM! Robust type coercion.

The helper correctly handles numbers, Dates, and other types with proper finite checks. The fallback to Number(value) is safe because Number.isFinite will catch invalid conversions.

---

20-53: Verify null value handling is intentional.

The domain validation logic is well-structured and correctly handles reversed domains (lines 29-31). However, lines 44-46 return true when the extracted value is null, treating null values as "within domain" by default.

This is likely intentional to support sparse data or missing values, but please confirm this behavior aligns with the expected user experience when dealing with incomplete datasets.

---

84-96: Clarify the behavior when entry is null.

The domain filtering logic correctly returns null when data falls outside the domain (lines 91-93), which achieves the PR objective. However, lines 87-89 return the clamped index as a string even when entry is null or undefined.

This could occur with sparse arrays or undefined entries. Is this intentional to handle edge cases in certain chart types, or could this lead to rendering issues when attempting to display a tooltip for non-existent data?

Consider whether returning null for undefined entries would be more consistent:

  if (entry == null) {
-   return String(clampedIndex);
+   return null;
  }

test/state/selectors/combiners/combineActiveTooltipIndex.spec.ts (1)

1-12: LGTM! Clean test setup.

The helper function createInteraction improves test readability and reduces duplication.